Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuya sequence fix #18085

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Tuya sequence fix #18085

merged 2 commits into from
Mar 3, 2023

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Mar 1, 2023

Description:

Related issue (if applicable): final fixes from #17625 (reply in thread)

  1. It happens sometimes that the driver's state machine sends a command but the EVERY_SECOND also send a Wifi State before the reponse from the command was received. This seems to loose the MCU in limbos.
    Now if a command is sent and no answer received, WifiState and others won't be sent from EVERY_SECOND unless a 200ms timeout expired

  2. It happens that some MCU would reset the ESP if it doesn't receive Wifi State 4 (connected to cloud) which is normally sent only after MQTT is connected. But is MQTT is not used, this is never sent and the ESP is resetted by the MCU
    Added a test to send Wifi State 4 as soon as Wifi is connected is MQTT is not enabled

  3. Changed the timer type in TuyaSNS result from signed (%d) to unsigned (%u) following Integer overflow for TuyaMCU timers (uint16 vs. int16) #18048

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.7
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit edb2fad into arendst:development Mar 3, 2023
@barbudor barbudor deleted the tuya_sequence_fix branch June 9, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants